Create new connection provider during IP failovers #117
Conversation
aegbert5
force-pushed
the
create-new-connection-provider-during-failovers
branch
2 times, most recently
from
75da1bb to
43ce57b
Compare
aegbert5
force-pushed
the
create-new-connection-provider-during-failovers
branch
from
43ce57b to
ea0a360
Compare
| @@ -111,7 +112,28 @@ class ConnectionProvider(props: Properties) { | |||
| val newIP: String = getIP | |||
| if (hasIpAddressChanged(pool, newIP)) { | |||
| // A failover has occurred, so we evict connections softly. New connectons look up the new IP address | |||
| pool.connectionProvider.map(_.getDataSource().getHikariPoolMXBean().softEvictConnections()) | |||
There was a problem hiding this comment.
I have a theory that softEvictConnections() does not permit future connections be opened within the same pool. Creating a new HikariPool from scratch will guarantee to use the new IP address returned from the CNAME URL
There was a problem hiding this comment.
Possibly we are running into brettwooldridge/HikariCP#1836 ?
I have a theory that softEvictConnections() does not permit future connections be opened within the same pool.
I don't thilnk that is right. Nothing in the documentation indicates that behavior.
However, brettwooldridge/HikariCP#228 does recommend replacing the entire pool, so I guess that might be a better approach.
| @@ -34,7 +34,8 @@ class ConnectionProvider(props: Properties) { | |||
| @volatile | |||
| private var cachedIpWithExpiration: Option[CachedIpWithExpiration] = None | |||
|
|
|||
| private val pool: Pool = new Pool(getIP) | |||
| @volatile | |||
There was a problem hiding this comment.
This is unnecessary since we only access it from within a synchronized block.
There was a problem hiding this comment.
We read from this value outside the synchronized block on lines 113, 115, and 139, for example to get a connection:
pool.connectionProvider.get.getConnection
Thus volatile will make sure the pool is assigned completely before we attempt to get connections from it
No description provided.