Dont use SchedulerFactory reserved prefixes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aegbert5
force-pushed
the
dont-use-reserved-prefixes-for-supporting-ip-failover
branch
from
0bf0ae7 to
0af292f
Compare
tmccombs
approved these changes
Oct 7, 2024
hunterrees
reviewed
Oct 7, 2024
| @@ -21,7 +21,7 @@ class ConnectionProvider(props: Properties) { | |||
| val logger = LoggerFactory.getLogger(this.getClass) | |||
| private val dataSource = props.getProperty("org.quartz.jobStore.dataSource") | |||
| private val jdbcURL = if (dataSource != null) props.getProperty("org.quartz.dataSource." + dataSource + ".URL") else null | |||
| private val detectIpAddressFailover = if (dataSource != null) props.getProperty("org.quartz.dataSource." + dataSource + ".ipFailover") == "true" else false | |||
| private val detectIpAddressFailover = props.getProperty("supportIPFailover") == "true" | |||
There was a problem hiding this comment.
I assume getProperty handles null values properly?
There was a problem hiding this comment.
Yes, props.getProperty("supportIPFailover") will return null if the value is not in the config. And null == "true" will return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the newest version of
piezo-adminwith theStdSchedulerFactoryprovided by quartz, the following exceptions are thrown:It seems that the
StdSchedulerFactoryin quartz is very protective of the configuration properties provided fororg.quartz.jobStore.dataSource={dataSourceName}. The properties set onorg.quartz.dataSource.{dataSourceName}must follow the provided pattern andorg.quartz.dataSource.{dataSourceName}.ipFailoveris not in that list by default:I think the best option is to use a different prefix for ipFailover that isn't already reserved by StdSchedulerFactory.scala