Add team to trigger monitoring record PROD-2741 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnnrj
force-pushed
the
PROD-2741-add-monitoring-team
branch
from
5363a0f to
7bcc843
Compare
alangshall
approved these changes
Jun 18, 2024
tnnrj
force-pushed
the
PROD-2741-add-monitoring-team
branch
from
7bcc843 to
0ff39b6
Compare
sriraamas
reviewed
Jun 18, 2024
| """) | ||
| prepared.setString(1, triggerKey.getName) | ||
| prepared.setString(2, triggerKey.getGroup) | ||
| prepared.setInt(3, triggerMonitoringPriority.id) | ||
| prepared.setInt(4, maxSecondsInError) | ||
| monitoringTeam match { |
There was a problem hiding this comment.
nit:
monitoringTeam.fold(prepared.setNull(5, java.sql.Types.VARCHAR))(team => prepared.setString(5, team))
There was a problem hiding this comment.
I generally tend to agree with this article by jhenline that argues that Option#fold is inconsistent and other ways of writing it are more readable
sriraamas
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a team value to the monitoring table and associated views.
Tested and working locally