Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add business icon (building-2) #496

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

maxim-s-barabash
Copy link
Contributor

@maxim-s-barabash maxim-s-barabash commented Feb 4, 2022

company_3_1

Screenshot from 2022-02-05 00-57-26

Icon Requests from Feather #119
Screenshot from 2022-03-28 19-13-29

@ericfennis
Copy link
Member

Welcome to the lucide community @maxim-s-barabash!
Is this not a duplicate of building ?

@ericfennis ericfennis added the 🎨 icon About new icons label Feb 5, 2022
@maxim-s-barabash
Copy link
Contributor Author

maxim-s-barabash commented Feb 5, 2022

no. this icon is associated with companies and businesses. other icon sets have separate icons for buildings, factories, and businesses.

@maxim-s-barabash
Copy link
Contributor Author

@ericfennis, what are the chances that he will be accepted?

@ericfennis
Copy link
Member

hmm. I think this feels a bit as a second building icon to me.
What do you think @locness3

@mittalyashu
Copy link
Member

This gives more of an enterprise feeling 😅

@Bowero
Copy link
Contributor

Bowero commented Mar 19, 2022

Personally I agree that this has different use cases than building.

@ericfennis
Copy link
Member

we don't have a naming officially yet, but we try to name it as what is look like or represents the object.
So maybe skyscraper will fit the best, or go for building-2

And make sure we add some tags like: business and enterprise to improve the search engine

@maxim-s-barabash maxim-s-barabash changed the title add business icon add business icon (building-2) Mar 28, 2022
@maxim-s-barabash
Copy link
Contributor Author

I renamed the icon

@ghost
Copy link

ghost commented Mar 28, 2022

Welcome! Thanks for your contribution. But the icon violates the guidelines. We can probably make it slightly different to make it stick to the guidelines?

@maxim-s-barabash
Copy link
Contributor Author

@delnyn, of course you can.

@ghost
Copy link

ghost commented Mar 30, 2022

image
here are some ideas

@ericfennis
Copy link
Member

@delnyn Can you try make a variant with a line on the bottom.

@ghost
Copy link

ghost commented Apr 2, 2022

image
Like this?

@ericfennis
Copy link
Member

ericfennis commented Apr 3, 2022

Niceee, I think these icons will match better with the existing "building" icons. What do you think @maxim-s-barabash @delnyn ?

image

@ghost
Copy link

ghost commented Apr 3, 2022

totally agree

icons/building-2.svg Outdated Show resolved Hide resolved
Co-authored-by: Eric Fennis <[email protected]>
@ericfennis ericfennis merged commit d99ee34 into lucide-icons:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants