Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subscript icon #459

Merged
merged 4 commits into from
Jan 1, 2022
Merged

Conversation

nabanita-sarkar
Copy link
Contributor

Subscript icon

image

Icon request

Closes #431

Original icon request from feather

feathericons/feather#511 (comment)

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, small optimisations for the code to make it smaller

icons/subscript.svg Outdated Show resolved Hide resolved
Co-authored-by: Eric Fennis <[email protected]>
@nabanita-sarkar
Copy link
Contributor Author

Thanks. I will optimize in future

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nabanita-sarkar
Copy link
Contributor Author

Is there something else for me to do so that this pr can be merged?

@mittalyashu
Copy link
Member

@ericfennis Should we also add "math" tag?

@ericfennis ericfennis merged commit 2af58f4 into lucide-icons:master Jan 1, 2022
@ericfennis
Copy link
Member

@mittalyashu I'm not exactly sure what you mean. Not the sigma (SUM) icon right?
https://lucide.dev/icon/sigma

@karsa-mistmere karsa-mistmere mentioned this pull request Jun 15, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Subscript
3 participants