-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new cursor icon #454
new cursor icon #454
Conversation
@pandrr Can you please rename it to |
@mittalyashu done! |
@pandrr this path needs to be cleaned up. And also, try to keep things aligned, evenly spaced, and with proper distance to the edge. |
Also the dash in the middle looks a bit weird to me, or is that me? |
I use windows and have only ever seen this one: On Font awesome its called Also, something like this could perhaps be useful as a |
yes on mac there is this little line in the middle |
@pandrr Oh wow didn't see that ! just noticed it. |
we cleaned up the icons and added a rename.svg as requested. |
@pandrr We've a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code formatting
@pandrr The cursor shape should probably also be cut up into three parts to avoid overlapping lines. Something like this: And there is no reason to not align these lines to the grid: |
Co-authored-by: Eric Fennis <[email protected]>
Co-authored-by: Eric Fennis <[email protected]>
thanks i commited those requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pandrr Awesome work!
@locness3 You ok with the naming of the files? |
a text cursor icon