Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new cursor icon #454

Merged
merged 8 commits into from
Jan 27, 2022
Merged

new cursor icon #454

merged 8 commits into from
Jan 27, 2022

Conversation

pandrr
Copy link
Contributor

@pandrr pandrr commented Dec 15, 2021

Screenshot 2021-12-15 at 14 39 58

a text cursor icon

@mittalyashu
Copy link
Member

@pandrr Can you please rename it to text-cursor?

@pandrr
Copy link
Contributor Author

pandrr commented Dec 29, 2021

@mittalyashu done!

@Andreto
Copy link
Member

Andreto commented Jan 1, 2022

@pandrr this path needs to be cleaned up.
image

And also, try to keep things aligned, evenly spaced, and with proper distance to the edge.
ICON DESIGN GUIDE

@ericfennis
Copy link
Member

Also the dash in the middle looks a bit weird to me, or is that me?

@Andreto
Copy link
Member

Andreto commented Jan 2, 2022

Also the dash in the middle looks a bit weird to me, or is that me? @ericfennis

I use windows and have only ever seen this one: image
But googling "text cursor icon" a lot of the results do have this line.

On Font awesome its called i-cursor: image
Is it perhaps a mac thing? I don't know?

Also, something like this could perhaps be useful as a rename or edit-text icon:
image

@Andreto
Copy link
Member

Andreto commented Jan 2, 2022

imageimage
image

@pandrr
Copy link
Contributor Author

pandrr commented Jan 3, 2022

yes on mac there is this little line in the middle

@ericfennis
Copy link
Member

@pandrr Oh wow didn't see that ! just noticed it.
But I think we need to keep it simple as possible.

@pandrr
Copy link
Contributor Author

pandrr commented Jan 11, 2022

we cleaned up the icons and added a rename.svg as requested.
i hope those are fine now. let me know

@mittalyashu
Copy link
Member

mittalyashu commented Jan 11, 2022

@pandrr We've a optimize script in package.json can you run that on those 2 icons?

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code formatting

icons/text-cursor.svg Outdated Show resolved Hide resolved
icons/rename.svg Outdated Show resolved Hide resolved
@Andreto
Copy link
Member

Andreto commented Jan 16, 2022

@pandrr
Keep separate lines as separate shapes for ease of editing.
This is both on the main cursor and the text box.

The cursor shape should probably also be cut up into three parts to avoid overlapping lines. Something like this:
image

And there is no reason to not align these lines to the grid:
image

@ericfennis
Copy link
Member

@pandrr @Andreto I fixed that in the formats, see suggestions.

Co-authored-by: Eric Fennis <[email protected]>
Co-authored-by: Eric Fennis <[email protected]>
@pandrr
Copy link
Contributor Author

pandrr commented Jan 19, 2022

thanks i commited those requests.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandrr Awesome work!

@ericfennis
Copy link
Member

@locness3 You ok with the naming of the files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants