-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gem icon #359
add gem icon #359
Conversation
Co-authored-by: b0b90 <[email protected]>
This is the gem icon which @b0b90 has provided in #350. I have optimized the paths and formatted the file svg file to match the Icon Design Guide. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Is there anything that I should change to get this merged? |
Doesn't fit much with the guidelines to me. |
Can you please explain in more detail what doesn't fit the guidelines from your point of view? |
Feels too dense. |
I think the edges are too sharp. This is one of those icons that are basically impossible to create with the padding from the style guide. Also tried to create my own version but I am not really convinced: |
@JanTrichter I this case the padding is not deeded, because it is one element. I agree with @locness3 that the lines looks a bit too dense to each other. |
@ericfennis I like your proposal. |
Remove additional edges of the gem and reduce height. Co-authored-by: Eric Fennis <[email protected]>
Thanks for your support! |
@connium No problem! |
Co-authored-by: b0b90 [email protected]