Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gem icon #359

Merged
merged 2 commits into from
Oct 6, 2021
Merged

add gem icon #359

merged 2 commits into from
Oct 6, 2021

Conversation

connium
Copy link
Contributor

@connium connium commented Jul 17, 2021

Co-authored-by: b0b90 [email protected]

gem

Co-authored-by: b0b90 <[email protected]>
@connium
Copy link
Contributor Author

connium commented Jul 17, 2021

This is the gem icon which @b0b90 has provided in #350. I have optimized the paths and formatted the file svg file to match the Icon Design Guide.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 17, 2021
@connium
Copy link
Contributor Author

connium commented Aug 21, 2021

Is there anything that I should change to get this merged?

@github-actions github-actions bot removed the Stale label Aug 22, 2021
@moeenio
Copy link
Contributor

moeenio commented Aug 23, 2021

Doesn't fit much with the guidelines to me.

@connium
Copy link
Contributor Author

connium commented Aug 23, 2021

Can you please explain in more detail what doesn't fit the guidelines from your point of view?

@moeenio
Copy link
Contributor

moeenio commented Aug 23, 2021

Feels too dense.

@JanTrichter
Copy link
Contributor

I think the edges are too sharp. This is one of those icons that are basically impossible to create with the padding from the style guide.

Also tried to create my own version but I am not really convinced:
https://diamond-comparison-cmx9st4f5-jantrichter.vercel.app/

@ericfennis
Copy link
Member

@JanTrichter I this case the padding is not deeded, because it is one element. I agree with @locness3 that the lines looks a bit too dense to each other.

@ericfennis
Copy link
Member

Less dens alternative:
image

@ericfennis ericfennis mentioned this pull request Sep 26, 2021
@connium
Copy link
Contributor Author

connium commented Oct 3, 2021

@ericfennis I like your proposal.

icons/gem.svg Outdated Show resolved Hide resolved
Remove additional edges of the gem and reduce height.

Co-authored-by: Eric Fennis <[email protected]>
@connium
Copy link
Contributor Author

connium commented Oct 4, 2021

Thanks for your support!

@ericfennis
Copy link
Member

@connium No problem!

@ericfennis ericfennis merged commit 7964a53 into lucide-icons:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants