Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added air-pressure icon #2554

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jamiemlaw
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Going part way to close issue #119 and Feather Icons issue #1246, adds an air-pressure icon to Lucide.

Icon use case

  • For use in a weather app

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

And slightly modified the `wind` icon to match
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Added or changed icons

icons/wind-arrow-down.svgicons/wind.svg

Preview cohesion icons/message-square-dot.svgicons/square-minus.svg
icons/wind-arrow-down.svgicons/wind.svg
icons/flask-conical.svgicons/circle-arrow-out-up-left.svg
Preview stroke widths icons/wind-arrow-down.svgicons/wind.svg
icons/wind-arrow-down.svgicons/wind.svg
icons/wind-arrow-down.svgicons/wind.svg
DPI Preview (24px) icons/wind-arrow-down.svg icons/wind.svg
Icon X-rays icons/wind-arrow-down.svg icons/wind.svg
Icon Diffs icons/wind-arrow-down.svg icons/wind.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const WindArrowDownIcon = createLucideIcon('WindArrowDown', [
  ["path",{"d":"M10 2v8"}],
  ["path",{"d":"M12.8 21.6A2 2 0 1 0 14 18H2"}],
  ["path",{"d":"M17.5 10a2.5 2.5 0 1 1 2 4H2"}],
  ["path",{"d":"m6 6 4 4 4-4"}]
])

const WindIcon = createLucideIcon('Wind', [
  ["path",{"d":"M12.8 19.6A2 2 0 1 0 14 16H2"}],
  ["path",{"d":"M17.5 8a2.5 2.5 0 1 1 2 4H2"}],
  ["path",{"d":"M9.8 4.4A2 2 0 1 1 11 8H2"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but name needs to be descriptive.

{
"$schema": "../icon.schema.json",
"contributors": [
"jamiemlaw"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you inherit the contributors here, or did you do a complete redesign?

And update the JSON file with contributors to the original `wind` icon and add `pressure` as a tag
@ericfennis
Copy link
Member

Nice icon @jamiemlaw !

@ericfennis ericfennis merged commit d2f7a09 into lucide-icons:main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants