fix(shared): Add trim to mergeClasses
#2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfennis
changed the title
ericfennis
changed the title
mergeClasses
jguddas
reviewed
Oct 8, 2024
jguddas
approved these changes
Oct 15, 2024
|
@ericfennis this needs |
benjick
reviewed
Oct 26, 2024
Co-authored-by: Max Malm <[email protected]>
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2498
Adds trim to
mergeClassesfunction. Possibly fixes hydration issues in NextJS.Also added a test and adjusted GH actions to run this change on each package.