Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added calendar-1 icon #2520

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

peteruithoven
Copy link
Contributor

@peteruithoven peteruithoven commented Oct 7, 2024

What is the purpose of this pull request?

  • New Icon

Description

Added new calendar-single icon.

Icon use case

Identifying events that will happen once and and don't repeat.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @colebemis
  • I've based them on the following Lucide icons: calendar, repeat-1
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Added or changed icons

icons/calendar-1.svg

Preview cohesion icons/square-dashed-mouse-pointer.svg
icons/calendar-1.svg
icons/calendar-fold.svg
Preview stroke widths icons/calendar-1.svg
icons/calendar-1.svg
icons/calendar-1.svg
DPI Preview (24px) icons/calendar-1.svg
Icon X-rays icons/calendar-1.svg
Icon Diffs icons/calendar-1.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const Calendar1Icon = createLucideIcon('Calendar1', [
  ["path",{"d":"M11 14h1v4"}],
  ["path",{"d":"M16 2v4"}],
  ["path",{"d":"M3 10h18"}],
  ["path",{"d":"M8 2v4"}],
  ["rect",{"x":"3","y":"4","width":"18","height":"18","rx":"2"}]
])

Adjust calendar position based on original
icons/calendar-single.svg Outdated Show resolved Hide resolved
jguddas

This comment was marked as duplicate.

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name should be calendar-one IMO

@karsa-mistmere
Copy link
Member

Name should be calendar-one IMO

That does not follow precedent of similar icons.

@karsa-mistmere karsa-mistmere changed the title feat(icons): added calendar-single icon feat(icons): added calendar-1 icon Oct 9, 2024
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just drop the rule that icons should not end with -[0-9]$ from lucide studio it's creating problems anyway.

icons/calendar-1.json Show resolved Hide resolved
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants