Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ski-jump icon #2516

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sateshcharan
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Added New ski-jump icon

Icon use case

  1. Use the ski jump icon to represent a section in a sports app that tracks winter sports achievements and competitions.
  2. Include the ski jump icon in a travel website's winter adventure section to highlight skiing destinations and ski jumping activities.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

Added or changed icons

icons/ski-jump.svg

Preview cohesion icons/square-dashed-kanban.svg
icons/ski-jump.svg
icons/toggle-left.svg
Preview stroke widths icons/ski-jump.svg
icons/ski-jump.svg
icons/ski-jump.svg
DPI Preview (24px) icons/ski-jump.svg
Icon X-rays icons/ski-jump.svg
Icon Diffs icons/ski-jump.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SkiJumpIcon = createLucideIcon('SkiJump', [
  ["path",{"d":"m12 19 1.53-1.55a1.594 1.594 0 0 0-.4-2.53l-2.64-1.37a2 2 0 0 1-.86-2.69l1.09-2.12a2 2 0 0 1 2.63-.84l.05.03a2 2 0 0 1 .86 2.7 1278 1278 0 0 0-1.99 3.84"}],
  ["path",{"d":"m3 23 17.72-2.82a4 4 0 0 0 2-.93L23 19"}],
  ["path",{"d":"M6 8 3 19"}],
  ["path",{"d":"m9.39 8.93-1.58-.79a2 2 0 0 0-.89-.21H5.39"}],
  ["circle",{"cx":"14.85","cy":"5.12","r":"2.05"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should be bigger
  • Should be centered
  • Has pretty sharp corners, should be rounder "lucidy-er"
  • skijump should be ski-jump or even ski-jumper
  • The head should have a radius of at least 2px IMO
  • The person should be bigger in general IMO, @jamiemlaw had the great suggestion for people styles: fix(icons): changed person-standing icon #2496 (comment)
  • Curves should be arcs example.

@sateshcharan
Copy link
Author

Hi, I've implemented the changes you suggested:

  • Size adjustments: The icon is now bigger and centered.
  • Corners: I've rounded the corners to give it a softer, more "lucid" feel.
  • Text correction: The label is updated to "ski-jump" or "ski-jumper" as per your preference.
  • Head radius: The head now has a radius of at least 2px.
  • Person icon: The person is now larger, following the suggestion from @jamiemlaw on improving the style.
  • Curves: The curves have been updated to arcs as an example.

Please let me know if there's anything else you'd like me to tweak.

@jamiemlaw
Copy link
Contributor

One fault with my person design (which I copied from GitHub!) is that I'm not sure how well it translates to smaller side-on figures. I have previously tried a wheelchair user and a cyclist, neither of which looked that good.

Here's a possible alternative. It has no ski poles, in part to reduce clutter and I also haven't seen any other ski jump icons with poles; it's more aligned to the grid, it has at least one-pixel gap around each edge; and there's a two-pixel gap between the skier and the skis.

I don't think it's perfect, though, but it's something.

icons
Open lucide studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants