Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aliasesSupport flag from rollup.config.mjs #1794

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

karsa-mistmere
Copy link
Member

closes #1789

What is the purpose of this pull request?

  • Bug fix

Description

Some UMD builds do not currently export icon aliases, this PR removes the aliasesSupport flag from rollup configs and turns the feature forcibly on by default.

Before Submitting

@karsa-mistmere karsa-mistmere added ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package ⚛️ preact package About the Preact Package labels Jan 10, 2024
@karsa-mistmere karsa-mistmere added the 🐛 bug Something isn't working label Jan 10, 2024
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can clean this all up

packages/lucide-preact/rollup.config.mjs Outdated Show resolved Hide resolved
packages/lucide-react/rollup.config.mjs Outdated Show resolved Hide resolved
packages/lucide-vue-next/rollup.config.mjs Outdated Show resolved Hide resolved
packages/lucide-vue/rollup.config.mjs Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member Author

We can clean this all up

@ericfennis fixed them all!

@ericfennis ericfennis merged commit d4cbe89 into main Jan 16, 2024
7 checks passed
@ericfennis ericfennis deleted the fix/1789-missing-aliases-in-umd-builds branch January 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⚛️ preact package About the Preact Package ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon not imported
3 participants