Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon podcast #132

Merged

Conversation

iiaishwarya
Copy link
Contributor

@iiaishwarya iiaishwarya commented Nov 12, 2020

For feather icon Podcast

image

@ericfennis
Copy link
Member

@sourcerer52 Welcome to the Lucide community, thanks for opening this PR!

I like the concept, but I think some lines are a bit distorted.
Can you try to make the waves perfectly round, like the radio icon ?

@ericfennis ericfennis added the 🎨 icon About new icons label Nov 13, 2020
@iiaishwarya
Copy link
Contributor Author

I see. How about this?

image

@moeenio
Copy link
Contributor

moeenio commented Nov 13, 2020

Wouldn't the radio icon fit for podcast?

@ericfennis
Copy link
Member

@locness3 I agree, but I think it's nice to have alternative icon with a mic. So I think we need to rename this icon to mic-radio or something.

@sourcerer52 This looks better. I noticed the line of the microphone holder is not perfectly round. Maybe it is a good idea to use the original mic icon and adjust it follow the guidelines.

@iiaishwarya
Copy link
Contributor Author

@ericfennis As per your suggestion, I used the mic-radio icon for the podcast. Have a look, if a further change is required.

image

@ericfennis
Copy link
Member

@sourcerer52 I think some elements in the icon are a bit distorted.
I hope this feedback maybe clears it more up.

  1. There need to be 2px between elements. See the Design Guide
  2. The microphone its self look distorted, please try to make it perfectly round like the red stroke I drew.
  3. The waves looks a bit off. I think they work better if you make them from the path of circle.

image

@iiaishwarya
Copy link
Contributor Author

Apologies for the delay. I was wondering if we could add something like this, the Apple podcast icon?

image

@ericfennis
Copy link
Member

@sourcerer52 Sorry for the late reply. I think this fits better. I tried some as wel, but it fastly becomes a mess. Feel free to submit!

icons/podcast.svg Outdated Show resolved Hide resolved
@ericfennis ericfennis merged commit 400f787 into lucide-icons:master Feb 6, 2021
@karsa-mistmere karsa-mistmere mentioned this pull request Jun 15, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants