Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unstorage): add ttl support #970

Merged

Conversation

Hebilicious
Copy link
Contributor

@Hebilicious Hebilicious commented Aug 14, 2023

Ttl support is being added to unstorage through unjs/unstorage#262
For now the vercel-kv and redis drivers are supported, but as more support is added, this will start working for all of them.

@vercel
Copy link

vercel bot commented Aug 14, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @pilcrowonpaper on Vercel.

@pilcrowonpaper first needs to authorize it.

@pilcrowonpaper
Copy link
Member

Do you know if the adapter breaks if you use this with unstorage <1.9? Wondering if this is a breaking change or if it can be a minor change.

@Hebilicious
Copy link
Contributor Author

@pilcrowonpaper I believe nothing would happen for older versions of unstorage and for drivers that don't support ttl. TransactionOptions were introduced here unjs/unstorage#168 (v1.2), so maybe you could set the minimum version to 1.2+ ?

@pilcrowonpaper
Copy link
Member

I guess this doesn't matter since since you can pass arbitrary arguments in Javascript without any errors. Can you add a new changeset with type set to "minor"?

@Hebilicious
Copy link
Contributor Author

Hebilicious commented Sep 7, 2023

I guess this doesn't matter since since you can pass arbitrary arguments in Javascript without any errors. Can you add a new changeset with type set to "minor"?

Sorry I'm a little confused, this project isn't using changeset, what should I do ?

Edit nvm, figured out the Auri stuff 👍🏽

.auri/$mqai142h.md Outdated Show resolved Hide resolved
@pilcrowonpaper pilcrowonpaper merged commit 904dbe3 into lucia-auth:main Sep 9, 2023
@pilcrowonpaper
Copy link
Member

Thanks!

@lucythecat lucythecat mentioned this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants