Wrap PR #17 #18
Merged
Wrap PR #17 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Windows. Otherwise, dispatchDynamic() in patchwork cannot locate non-existing functions and replace() returns null instead of expected value.
This reverts commit a556118
We cannot run tests on 8.0 so far, as phpunit8+ require that "setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void". All tests should be edited accordingly.
No backward compatibility with php 5.6 - 7.1. Should be tagged as the next version of function-mocker: 2.0.0.
"phpunit/phpunit": "8.5 - 9.4" in composer.json makes it automatically. On php 7.2: phpunit 8.5 On php 7.3 - 8.0: phpunit 9.4
|
Thank you for merging my PR. Could you also tag the latest commit in master as 1.4.0? Tests with FunctionMocker work on PHP 5.6-8.0: https://github.com/hCaptcha/hcaptcha-wordpress-plugin/actions/runs/1107542574, but I have to specify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.