Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored keyboard safe area on iPhone. #97

Closed
VadimQw opened this issue Sep 5, 2022 · 1 comment · Fixed by #100 or #130
Closed

Ignored keyboard safe area on iPhone. #97

VadimQw opened this issue Sep 5, 2022 · 1 comment · Fixed by #100 or #130
Labels
bug Something isn't working

Comments

@VadimQw
Copy link

VadimQw commented Sep 5, 2022

Describe the bug
Keyboard safe area ignored if activated.

Expected behavior
Bottom sheet consider keyboard height.

Target version

  • Environment: iOS
  • Version: 15.0

Additional context
On 'BottomSheetView' use '.ignoresSafeArea(.container, edges: .bottom)' for iPhone instead '.edgesIgnoringSafeArea(.bottom)'.
@lucaszischka lucaszischka added the bug Something isn't working label Sep 5, 2022
@ghost ghost mentioned this issue Sep 6, 2022
Merged
@lucaszischka lucaszischka linked a pull request Sep 6, 2022 that will close this issue
iPad Bottom Sheet, but at the Bottom ✨ #100
Merged
chocoford pushed a commit to chocoford/BottomSheet that referenced this issue Jun 16, 2023
fix "Ignored keyboard safe area on iPhone." lucaszischka#97
cebd220
@chocoford chocoford mentioned this issue Jun 16, 2023
Merged
@chocoford
Copy link
Contributor

The problem is still here.

Target version

Environment: iOS
Version: 16.0

I have raised a PR #130, using .ignoresSafeArea(.container, edges: .bottom) to replace '.edgesIgnoringSafeArea(.bottom) for iOS version greater than 14.0.

lucaszischka pushed a commit that referenced this issue Jun 26, 2023
Fix #97 (#130)
3f1d7f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@chocoford @VadimQw @lucaszischka