fix(nx-python): replace poetry update with poetry lock and poetry install when adding a new package #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tall when adding a new package currently, when there are more than 2 levels of local projects dependencies, when a dependency is added to the 2 level or deeper the nx python plugin uses poetry update <lib> to update to keep all the poetry.lock in sync. however, the poetry update only works well for the first level, for all the others the poetry lock is not updated correctly. the combination of poetry lock and only running poetry install when the root pyproject.toml is not present, updates the poetry.lock for all the levels of dependencies.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [19.0.1](nx-python-v19.0.0...nx-python-v19.0.1) (2024-08-09) ### Bug Fixes * **nx-python:** replace poetry update with poetry lock and poetry install when adding a new package ([#243](#243)) ([b311fcb](b311fcb))
|
🎉 This PR is included in version 19.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently, when there are more than 2 levels of local project dependencies, when a dependency is added to the 2 levels or deeper the nx python plugin uses
poetry update <lib>to update to keep all thepoetry.lockin sync.however, the poetry update only works well for the first level, for all the others the poetry lock is not updated correctly.
Expected Behavior
the combination of
poetry lockand only runningpoetry installwhen the rootpyproject.tomlis not present, updates thepoetry.lockfor all the levels of dependencies.