feat(nx-python): automatically activate shared virtual environment #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes all the `@nxlv/python` executors to first verify if the shared virtual environment is available in the workspace, if yes, activate before running the commands, also adds a new `@nxlv/python:run-commands` executors to wrap the `nx:run-commands` and activate the virtual environment before running the commands, if you are using `@nxlv/python` version 16> you can use this following command to migrate all your `nx:run-commands` to `@nxlv/python:run-commands`: `npx nx migrate @nxlv/python` re #132
1 task
|
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the monorepo workspace uses the shared virtual environment mode, the user is obligated to activate the root virtual environment before running any
@nxlv/pythonexecutors, like,test,lint, andbuild.Expected Behavior
If the root
pyproject.tomlhas the following configuration:All the
@nxlv/pythoncommands will check if some virtual environment is already activated, if not, first activate the virtual environment before running the commands.This PR also adds a new executor
@nxlv/python:run-commandsthat wraps the defaultnx:run-commandsand performs the action described above to activate the virtual environment first.If you are using
@nxlv/pythonversion 16> you can use the following command to migrate all yournx:run-commandsto@nxlv/python:run-commands:Related Issue(s)
Reference #132