Feedback from design reviews (#76)

* Change release date for this site

* Add site links

* Capitalize m in About Me

* Update contact links in resume

* Update Chinese text

* Feedback from family

* Feedback from family

* Tagline from content, not component

* Add spacing between paragraphs in the pitch.

* View site button on projects with a site

* Larger font on pitch

* Make pitch tagline about me

* Fix broken integration test

content/pages/1--about/index.md

@@ -1,10 +1,10 @@
 ---
-title: About me
+title: About Me
 ---
-I'm a full stack engineer with a focus on data and a broad variety of experience. I will build robust systems that effectively collect and clean your data.
+I'm a full stack engineer with a focus on data and a broad range of experience. I am able to build robust systems that effectively collect and clean data.
 
-I have worked at enterprise scale for two years, and have worked on roles in diverse areas such as application development, devops, and quality. The application I maintained and improved has performed over 1 million deployments, and I know that because I built the metrics pipeline for it.
+I have worked at enterprise scale for two years, and have worked in a variety of roles including application development, devops, and quality. The deployment tool I maintained and improved has performed over 1 million deployments within the company, and I know that because I built the data collection infrastructure for it.
 
-When I'm not maintaining the release pipelines at Intuit, I love traveling, going on long walks with my family, and automating everything possible in my house. I've lived in 3 1/2 countries and want to one day have lived on every continent. (Maybe not Antarctica)
+I've lived on 3 continents and speak four languages. When I'm not working, I love traveling, cooking new foods, learning languages, and automating everything possible in my house.
 
 Want to know more? Feel free to send me an email or browse some of my projects.

content/parts/author.md

@@ -2,4 +2,4 @@
 title: author
 ---
 
-**Lucas Kjaero-Zhang** I'm a full stack engineer with a focus on data, located in San Diego, California. When I'm not maintaining the release pipelines at Intuit, I love traveling, going on long walks with my family, and automating everything possible in my house.
+**Lucas Kjaero-Zhang** I'm a full stack engineer with a focus on data, located in San Diego, California. When I'm not working, I love traveling, cooking new foods, learning languages, and automating everything possible in my house.

content/parts/pitch.md

@@ -1,10 +1,11 @@
 ---
 title: pitch
+tagline: Well-rounded with a love of data
 ---
 
 I'm a full stack engineer with a focus on data and a broad variety of experience. I will build robust systems that effectively collect and clean your data.
 
-I have worked at enterprise scale for two years, and have worked on roles in diverse areas such as application development, devops, and quality. The application I maintained and improved has performed over 1 million deployments, and I know that because I built the metrics pipeline for it.
+I have worked at enterprise scale for two years, and have worked in a variety of roles including application development, devops, and quality. The deployment tool I maintained and improved has performed over 1 million deployments within the company, and I know that because I built the data collection infrastructure for it.
 
 I'm passionate about bringing valuable and actionable insights from your data. I work best with teams.
 

content/posts/2015-2-01--Puzzle-8/index.md

@@ -6,6 +6,7 @@ technologies: ["python"]
 tldr: Created an object-oriented Python program to solve sliding tile puzzles with an A* search and multiple heuristics.
 for: school
 source:
+site:
 ---
 Created a Python program to solve sliding tile puzzles with an A* search and multiple heuristics. Finds solutions with the fewest possible number of moves.
 

content/posts/2017-06-21--pycasia/index.md

@@ -6,6 +6,7 @@ technologies: ["python", "numpy"]
 tldr: An open-source python library to work with the CASIA Chinese handwriting database.
 for: personal
 source: https://github.com/lucaskjaero/PyCasia
+site: https://pypi.org/project/Pycasia/
 ---
 An open-source python library to work with the CASIA Chinese handwriting database. Reads custom binary filetypes to prepare for machine learning applications.
 

content/posts/2017-07-02--MNIST/index.md

@@ -6,6 +6,7 @@ technologies: ["python", "keras", "numpy", "pandas", "tensorflow"]
 tldr: Created a computer vision model to recognize handwritten digits with 99% accuracy ranked in top 36% globally of all Kaggle users.
 for: personal
 source: https://github.com/lucaskjaero/MNIST
+site:
 ---
 Created a computer vision model to recognize handwritten digits with 99% accuracy. Model ranked in the top 36% globally of all Kaggle users. Used a Convolutional Neural Network implemented in TensorFlow.
 

content/posts/2017-07-21--Lucas-Kjaero-Website/index.md

@@ -6,6 +6,7 @@ technologies: ["python", "sql", "django"]
 tldr: My old portfolio website, built using Django and served on Heroku
 for: personal
 source: https://github.com/lucaskjaero/LucasKjaero.com
+site: https://murmuring-hamlet-3859.herokuapp.com/
 ---
 A portfolio website to display projects, resume, and contact information. The website was built using Django, and was served on Heroku.
 

content/posts/2017-12-01--FFFF-Performance/index.md

@@ -6,6 +6,7 @@ technologies: ["scala", "jenkins", "gatling"]
 tldr: Created a suite of performance scripts to prepare the site for the predicted traffic of the 2017 tax season as the team's sole performance engineer.
 for: Intuit
 source:
+site: https://www.freefilefillableforms.com
 ---
 I created a suite of performance testing scripts for Free File Fillable Forms, and used these scripts to prepare the site for the predicted traffic of the 2017 tax season as the team's sole performance engineer.
 

content/posts/2019-03-28--RELENG-Docker/index.md

@@ -6,6 +6,7 @@ technologies: ["docker", "java", "spring boot"]
 tldr: Created a suite of docker containers allowing new hires to begin local development on day one.
 for: Intuit
 source:
+site:
 ---
 Created a suite of docker containers allowing new hires to begin local development on day one. Prior to the docker setup, local development was a pain point, with no team-member having all micro-services set up locally, and development frequently occurred in local environments
 

content/posts/2019-06-26--Metrics-Dashboard/index.md

@@ -6,6 +6,7 @@ technologies: ["spring boot", "java", "jms", "aws", "kinesis", "elasticsearch",
 tldr: Created a data collection pipeline and release information dashboard to enable leaders to self-serve deployment metrics.
 for: Intuit
 source:
+site:
 ---
 Led a team of three engineers to create a data collection pipeline and release information dashboard to enable leaders to self-serve deployment metrics. This dashboard replaced manual queries from directors, enabling them to get data instantly.
 

content/posts/2019-12-22--Lucas-Kjaero-Zhang-Website/index.md → content/posts/2020-01-05--Lucas-Kjaero-Zhang-Website/index.md

@@ -6,6 +6,7 @@ technologies: ["aws", "gatsby", "graphql", "javascript", "latex", "react"]
 tldr: This website! Displays projects and contact information using react and S3.
 for: personal
 source: https://github.com/lucaskjaero/lucas-kjaero-website
+site: 
 ---
 A portfolio website to display projects, resume, and contact information. This website is entirely static content, served from an S3 bucket with no backend servers involved.
 

cypress/integration/about.test.js

@@ -1,6 +1,6 @@
 describe("Check the about page", function() {
   it("Loads about page", function() {
     cy.visit("/about/");
-    cy.get("h1").should("contain", "About me");
+    cy.get("h1").should("contain", "About Me");
   });
 });

resume/lucas-kjaero-zhang-resume.tex

@@ -79,7 +79,7 @@
 % -linked-in profile
 
 \address{(619) 905-1772\\San Diego, CA}
-\address{\href{mailto:lucas@lucaskjaero.com}{Lucas@LucasKjaero.com}\\\href{http://www.lucaskjaero.com}{www.LucasKjaero.com}}
+\address{\href{mailto:lucas@lucaskjaerozhang.com}{Lucas@LucasKjaeroZhang.com}\\\href{https://www.lucaskjaerozhang.com}{www.LucasKjaeroZhang.com}}
 
 % Uncomment to add a third address
 

resume/lucas-kjaero-zhang-个人简历.tex

@@ -43,7 +43,7 @@
 %
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-\documentclass[margin]{res}  
+\documentclass[margin]{res}
 
 % Default font is the helvetica postscript font
 \usepackage{helvet}
@@ -73,15 +73,15 @@
 %-------------------------------------------------------------------------------
 %	NAME AND ADDRESS SECTION
 %-------------------------------------------------------------------------------
-\name{Lucas Kj\ae{}r\o{}}
+\name{Lucas Kj\ae{}r\o{}-Zhang}
 
 % Note that addresses can be used for other contact information:
 % -phone numbers
 % -email addresses
 % -linked-in profile
 
 \address{电话号码：+1 \(619\) 905-1772\\永久住址： San Diego, CA 92123}
-\address{邮箱地址：\href{mailto:lucas@lucaskjaero.com}{Lucas@LucasKjaero.com}\\个人网址：\href{http://www.lucaskjaero.com}{www.LucasKjaero.com}}
+\address{邮箱地址：\href{mailto:lucas@lucaskjaerozhang.com}{Lucas@LucasKjaeroZhang.com}\\个人网址：\href{https://www.lucaskjaerozhang.com}{www.LucasKjaeroZhang.com}}
 
 % Uncomment to add a third address
 %\address{Address 3 line 1\\Address 3 line 2\\Address 3 line 3}
@@ -94,7 +94,7 @@
 %----------------------------------------------------------------------------------------
 
 \section{}
-To view English version, visit \href{http://www.lucaskjaero.com/resume/}{http://www.lucaskjaero.com/resume/}
+To view English version, visit \href{https://www.lucaskjaerozhang.com/lucas-kjaero-zhang-resume.pdf}{https://www.lucaskjaero.com/lucas-kjaero-zhang-resume.pdf}
 
 %-------------------------------------------------------------------------------
 %	EDUCATION SECTION

src/components/Pitch/Pitch.js

@@ -2,12 +2,12 @@ import React from "react";
 import PropTypes from "prop-types";
 
 const Pitch = props => {
-  const { html, theme } = props;
+  const { html, tagline, theme } = props;
 
   return (
     <React.Fragment>
       <section className="pitch">
-        <h2>The perfect addition to your team</h2>
+        <h2>{tagline}</h2>
         <div className="pitchtext" dangerouslySetInnerHTML={{ __html: html }} />
       </section>
 
@@ -25,6 +25,10 @@ const Pitch = props => {
           padding-bottom: ${theme.header.height.homepage};
         }
 
+        .pitchtext p {
+          margin-bottom: 2em;
+        }
+
         h2 {
           text-align: center;
           font-size: ${theme.hero.h1.size};
@@ -52,7 +56,7 @@ const Pitch = props => {
 
         .pitchtext {
           display: block;
-          font-size: 16px;
+          font-size: ${theme.font.size.m};
           text-align: center;
           padding-right: 15%;
           padding-left: 15%;
@@ -79,6 +83,7 @@ const Pitch = props => {
 
 Pitch.propTypes = {
   html: PropTypes.string.isRequired,
+  tagline: PropTypes.object.isRequired,
   theme: PropTypes.object.isRequired
 };
 

src/components/Post/Post.js

@@ -7,14 +7,14 @@ import Bodytext from "../Article/Bodytext";
 import Meta from "./Meta";
 import Author from "./Author";
 import NextPrev from "./NextPrev";
-import Source from "./Source";
+import ViewButton from "./ViewButton";
 
 const Post = props => {
   const {
     post: {
       html,
       fields: { prefix },
-      frontmatter: { title, author, category, source, technologies }
+      frontmatter: { title, author, category, site, source, technologies }
     },
     authornote,
     next: nextPost,
@@ -35,7 +35,8 @@ const Post = props => {
         />
       </header>
       <Bodytext html={html} theme={theme} />
-      <Source source={source} theme={theme} />
+      <ViewButton link={source} text="View Source" theme={theme} />
+      <ViewButton link={site} text="View Site" theme={theme} />
       <footer>
         <Author note={authornote} theme={theme} />
         <NextPrev next={nextPost} prev={prevPost} theme={theme} />

src/components/Post/Source.js → src/components/Post/ViewButton.js

@@ -2,22 +2,23 @@ import React from "react";
 import PropTypes from "prop-types";
 import Button from "antd/lib/button";
 
-const Source = props => {
-  const { source, theme } = props;
+const ViewButton = props => {
+  const { link, text, theme } = props;
 
-  if (source && source != "") {
+  if (link && link != "") {
     return (
       <React.Fragment>
         <div className="source">
-          <Button type="primary" href={source}>
-            View Source
+          <Button type="primary" href={link}>
+            {text}
           </Button>
         </div>
 
         {/* --- STYLES --- */}
         <style jsx>{`
-          .ant-btn-primary {
+          a {
             background-color: ${theme.background.color.brand};
+            margin-bottom: 2em;
           }
         `}</style>
       </React.Fragment>
@@ -27,9 +28,10 @@ const Source = props => {
   }
 };
 
-Source.propTypes = {
-  source: PropTypes.string,
+ViewButton.propTypes = {
+  link: PropTypes.string,
+  text: PropTypes.string.isRequired,
   theme: PropTypes.object.isRequired
 };
 
-export default Source;
+export default ViewButton;

src/layouts/index.js

@@ -152,9 +152,6 @@ class Layout extends React.Component {
                       h1 {
                         letter-spacing: -0.04em;
                       }
-                      p {
-                        margin: 0;
-                      }
                       strong {
                         font-weight: ${this.state.font600loaded ? 600 : 400};
                       }

src/pages/index.js

@@ -19,7 +19,10 @@ class IndexPage extends React.Component {
     const {
       data: {
         posts: { edges: posts = [] },
-        pitch: { html: pitch },
+        pitch: {
+          html: pitch,
+          frontmatter: { tagline }
+        },
         bgDesktop: {
           resize: { src: desktop }
         },
@@ -49,7 +52,7 @@ class IndexPage extends React.Component {
         <hr ref={this.separator1} />
 
         <ThemeContext.Consumer>
-          {theme => <Pitch html={pitch} theme={theme} />}
+          {theme => <Pitch html={pitch} tagline={tagline} theme={theme} />}
         </ThemeContext.Consumer>
 
         <hr ref={this.separator2} />
@@ -102,6 +105,9 @@ export const query = graphql`
     }
     pitch: markdownRemark(fileAbsolutePath: { regex: "/pitch/" }) {
       html
+      frontmatter {
+        tagline
+      }
     }
     bgDesktop: imageSharp(fluid: { originalName: { regex: "/lucas-background/" } }) {
       resize(width: 1200, quality: 90, cropFocus: CENTER) {

src/templates/PostTemplate.js

@@ -52,6 +52,7 @@ export const postQuery = graphql`
       frontmatter {
         title
         category
+        site
         source
         technologies
       }