Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account feature #80

Merged
merged 29 commits into from
Mar 25, 2021
Merged

Account feature #80

merged 29 commits into from
Mar 25, 2021

Conversation

lucashuy
Copy link
Owner

@lucashuy lucashuy commented Mar 21, 2021

Sorry about the large pull request.

This request closes #2.

This request will resolve the following user stories:

This request will additionally close the following dev tasks:

This pull request will contain the tests for previously done tasks for feature #2.

The frontend now contains a Profile. The profile has the password, avatar and personal details settings. All profile related React components are prefixed by Profile. Additionally, helper components have been created to make reuse of them easier (Button, Input, RoundedBox, StatusMessage).

@lucashuy lucashuy added this to the Sprint 3 milestone Mar 21, 2021
Copy link
Collaborator

@humayraR humayraR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as thoroughly as I could lol. Frontend looks good enough (i don't have much experience so can't say). Put in a few comments here and there for backend.

gamersnet_backend/persistence/avatar.js Show resolved Hide resolved
gamersnet_backend/persistence/users.js Show resolved Hide resolved
gamersnet_backend/persistence/users.js Outdated Show resolved Hide resolved
gamersnet_backend/routes/users/getAvatar.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@humayraR humayraR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR, tried my best to review it thoroughly. It looks good to me.

@humayraR humayraR merged commit c7e550d into master Mar 25, 2021
@lucashuy lucashuy deleted the account_feature branch April 16, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants