-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account feature #80
Account feature #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed as thoroughly as I could lol. Frontend looks good enough (i don't have much experience so can't say). Put in a few comments here and there for backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge PR, tried my best to review it thoroughly. It looks good to me.
Sorry about the large pull request.
This request closes #2.
This request will resolve the following user stories:
This request will additionally close the following dev tasks:
This pull request will contain the tests for previously done tasks for feature #2.
The frontend now contains a
Profile
. The profile has the password, avatar and personal details settings. All profile related React components are prefixed byProfile
. Additionally, helper components have been created to make reuse of them easier (Button
,Input
,RoundedBox
,StatusMessage
).