feat(add-open-settings-uri-context) #152
Open
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support passing uri into the openSettings so menus such as file manager permissions can open with the settings intent - add uri option parameter to all sections of the app. - default uri to null if not provided by the API and pass the null value to the native side.
FrederickEngelhardt
force-pushed
the
feat/add-open-settings-uri-context
branch
from
5a173c1
to
5c0c63d
Compare
FrederickEngelhardt
force-pushed
the
feat/add-open-settings-uri-context
branch
from
232d730
to
372419d
Compare
| @@ -16,7 +16,7 @@ android { | |||
| minSdkVersion _minSdkVersion | |||
| targetSdkVersion _targetSdkVersion | |||
| versionCode 28 | |||
| versionName "1.3.0" | |||
| versionName "1.3.1" | |||
There was a problem hiding this comment.
Feel free to roll this back.
|
Hi @FrederickEngelhardt this looks pretty cool ;) |
2 similar comments
|
Hi @FrederickEngelhardt this looks pretty cool ;) |
|
Hi @FrederickEngelhardt this looks pretty cool ;) |
|
@lucasferreira Just following up. Does this change seem acceptable. If so, can we merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions:
Edit:
"react-native-send-intent": "git+https://github.com/FrederickEngelhardt/react-native-send-intent/#feat/add-open-settings-uri-context". FYI with this method cache is nasty. Run this if you need to make updatesyarn cache clean react-native-send-intent. Symlinks can also work but they require metro workarounds.I tested this and links work well. So I think this feature is stable. Without the URI nothing will navigate but that's fine.
Example code