Internal change

PiperOrigin-RevId: 228182908
luca-digrazia · Sep 4, 2022 · acbef70 · acbef70
1 parent 1356ccd
commit acbef70
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 61 deletions.
diff --git a/...bazelbuild.bazel/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java b/...bazelbuild.bazel/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java
@@ -136,7 +136,7 @@ final void signalDepInternal(boolean childChanged, boolean isReady) {
         this);
     if (!isChanged()) {
       // Synchronization isn't needed here because the only caller is NodeEntry, which does it
-      // through the synchronized method signalDep.
+      // through the synchronized method signalDep(Version).
       if (childChanged) {
         dirtyState = DirtyState.NEEDS_REBUILDING;
       } else if (dirtyState == DirtyState.CHECK_DEPENDENCIES

diff --git a/.../bazelbuild.bazel/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/.../bazelbuild.bazel/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -13,6 +13,7 @@
 // limitations under the License.
 package com.google.devtools.build.skyframe;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.MoreObjects;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
@@ -140,7 +141,7 @@ public class InMemoryNodeEntry implements NodeEntry {
    * Object encapsulating dirty state of the object between when it is marked dirty and
    * re-evaluated.
    */
-  @Nullable protected volatile DirtyBuildingState dirtyBuildingState = null;
+  @VisibleForTesting @Nullable protected volatile DirtyBuildingState dirtyBuildingState = null;
 
   private static final int NOT_EVALUATING_SENTINEL = -1;