-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement key map overrides for jogging. #283
Conversation
Nice - indeed the shortkeys management need improvement
Has you did the shortcut management already from API point of view it just need an additionnal list type (shortkeys) to be displayed properly and use json and parse them Let me know what do you think , |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
there is no current support for combination key shortcut, I am not sure it will be address in this PR, original implementation was as simple as possible - waiting for feedback and this PR is the first one I got @aaronse sorry I have just make some change for current consistency issue raised by @V1EngineeringInc - just rebase your fork should fix the conflict - you do not need to rebuild package - it is better to build only at the end because need changing version as well, so you can leave it to me |
Hmm, wasn't sure how to reopen/continue this pull request after rebasing to absorb recent edits. Ended up creating #284 which references this one. Will continue discussion there unless you say otherwise. Cheers! |
sure - thank you |
Enable Users to optionally adapt/define/suppress key shortcuts for their machine and keyboard setups.
Sent this pull request to better help communicate the ask, and a possible solution approach.