Refactor #31
Closed
Refactor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludo237
reviewed
Mar 20, 2018
| 'display_name' => $request->display_name, | ||
| 'description' => $request->description, | ||
| ]); | ||
| $role->update($request->only(['name', 'display_name', 'description'])); |
There was a problem hiding this comment.
Even thought this may seems a good refactoring, sometimes the raw model could not have a 1:1 match with a form fields name.
I think the old way it's better right now because one simple thing:
- Controllers are not backed-up by tests
|
Feel free to close this if you do not like it. |
|
The problem is not whether I like or not, it's about bring logic to refactors. Refactoring an untested code is always risky |
|
Agree with what @ludo237 mentioned, personally want to refactor many parts of the code. On my list to review complete code and plan out refactoring in the best possible way. @imanghafoori1 closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor to reach fewer lines of code