Fix bug in ZstdBufferDecompressingStream when array backing ByteBuffer is shared #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
What was the impact to OpenSearch users due to this bug? Would they sometimes hit this exception, under specific circumstances? Always hit it? During indexing (maybe merging, which might decompress stored fields) or searching (when also retrieving stored fields)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of ZstdBufferDecompressingStream fails with
com.github.luben.zstd.ZstdIOException: Unknown frame descriptorwhen the interface is used with a ByteBuffer which is backed by an array which is shared with other ByteBuffers. This is a bug in the implementation where we assume that the ByteBuffer represents the view of the entire backing array.Change
Change the implementation to specifically use the array represented by the bytebuffer view instead of the entire backing array.
Testing
Added a test case which fails prior to the change and passes after it.