Disallow burning externally locked nfts (paritytech#13054)

* Disallow burning externally locked nfts * Update docs
ltfschoen · Feb 22, 2023 · c53479b · c53479b
1 parent 1a3a17c
commit c53479b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/frame/nfts/src/features/create_delete_item.rs b/frame/nfts/src/features/create_delete_item.rs
@@ -91,6 +91,7 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 		item: T::ItemId,
 		with_details: impl FnOnce(&ItemDetailsFor<T, I>) -> DispatchResult,
 	) -> DispatchResult {
+		ensure!(!T::Locker::is_locked(collection, item), Error::<T, I>::ItemLocked);
 		let owner = Collection::<T, I>::try_mutate(
 			&collection,
 			|maybe_collection_details| -> Result<T::AccountId, DispatchError> {

diff --git a/frame/nfts/src/lib.rs b/frame/nfts/src/lib.rs
@@ -856,7 +856,9 @@ pub mod pallet {
 
 		/// Destroy a single item.
 		///
-		/// Origin must be Signed and the sender should be the Admin of the `collection`.
+		/// Origin must be Signed and the signing account must be either:
+		/// - the Admin of the `collection`;
+		/// - the Owner of the `item`;
 		///
 		/// - `collection`: The collection of the item to be burned.
 		/// - `item`: The item to be burned.

diff --git a/frame/uniques/src/functions.rs b/frame/uniques/src/functions.rs
@@ -189,6 +189,7 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 		item: T::ItemId,
 		with_details: impl FnOnce(&CollectionDetailsFor<T, I>, &ItemDetailsFor<T, I>) -> DispatchResult,
 	) -> DispatchResult {
+		ensure!(!T::Locker::is_locked(collection, item), Error::<T, I>::Locked);
 		let owner = Collection::<T, I>::try_mutate(
 			&collection,
 			|maybe_collection_details| -> Result<T::AccountId, DispatchError> {

diff --git a/frame/uniques/src/lib.rs b/frame/uniques/src/lib.rs
@@ -577,7 +577,9 @@ pub mod pallet {
 
 		/// Destroy a single item.
 		///
-		/// Origin must be Signed and the sender should be the Admin of the `collection`.
+		/// Origin must be Signed and the signing account must be either:
+		/// - the Admin of the `collection`;
+		/// - the Owner of the `item`;
 		///
 		/// - `collection`: The collection of the item to be burned.
 		/// - `item`: The item of the item to be burned.