Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44969: add missing filters #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DM-44969: add missing filters #478

wants to merge 1 commit into from

Conversation

PaulPrice
Copy link
Contributor

No description provided.

@PaulPrice PaulPrice requested a review from timj June 24, 2024 22:18
@timj
Copy link
Member

timj commented Jun 24, 2024

@ijiraq you can comment on this PR.

@timj
Copy link
Member

timj commented Jun 24, 2024

A quick test shows that we do get the new filters:

$ butler create tmp
 $ butler register-instrument tmp lsst.obs.subaru.HyperSuprimeCam
$ butler query-dimension-records tmp physical_filter
instrument   name    band 
---------- ------- -------
       HSC  EB-gri     gri
       HSC  ENG-R1       r
       HSC   HSC-G       g
       HSC   HSC-I       i
       HSC  HSC-I2       i
       HSC   HSC-R       r
       HSC  HSC-R2       r
       HSC   HSC-Y       y
       HSC   HSC-Z       z
       HSC  IB0945    I945
       HSC  NB0387    N387
       HSC  NB0391    N391
       HSC  NB0395    N395
       HSC  NB0400    N400
       HSC  NB0430    N430
       HSC  NB0468    N468
       HSC  NB0497    N497
       HSC  NB0506    N506
       HSC  NB0515    N515
       HSC  NB0527    N527
       HSC  NB0656    N656
       HSC  NB0718    N718
       HSC  NB0816    N816
       HSC  NB0872    N872
       HSC  NB0921    N921
       HSC  NB0926    N926
       HSC  NB0973    N973
       HSC  NB1010   N1010
       HSC      PH      PH
       HSC      SH      SH
       HSC   empty   white
       HSC unknown unknown

timj
timj reviewed Jun 25, 2024
View reviewed changes
config/filterMap.py Outdated
('NB0921', 'z'),
('NB0926', 'z'),
('NB0973', 'y'),
('NB1010', 'y'),
# Intermediate bands
('IB0945', 'z'),
# Extended bands
('EB-gri', 'r'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reasons I'm not entirely clear about, but which I might have inherited from the gen2 code, the metadata translator upper cases the filter name so this has to be EB-GRI for the ingest to work.

Copy link
Member

@timj timj Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this config is used for but should this be "gri" band to match the definition below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It selects which band to use for photometric calibration. This says "for filter EB-GRI, calibrate against r".

@PaulPrice
add missing filters
ebe9fd6 
A bunch of NB filters and the g+r+i filter for Solar System work.
timj
timj approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I've checked that I can ingest a raw file. I've started a Jenkins run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulPrice @timj