Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38669: Add workaround for Python threading bug #231

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

andy-slac
Copy link
Collaborator

The bug causes occasional issues with multi-process pipeline executions with pytest using concurrent running. This is a known issue (python/cpython#102512) which will eventually be fixed in Python, at that time the patch should become no-op and can be removed.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The bug causes occasional issues with multi-process pipeline executions
with pytest using concurrent running. This is a known issue
(python/cpython#102512) which will eventually
be fixed in Python, at that time the patch should become no-op and can
be removed.
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.06 ⚠️

Comparison is base (dd9b229) 82.90% compared to head (5af61ce) 82.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   82.90%   82.85%   -0.06%     
==========================================
  Files          46       46              
  Lines        4113     4118       +5     
  Branches      770      772       +2     
==========================================
+ Hits         3410     3412       +2     
- Misses        520      522       +2     
- Partials      183      184       +1     
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/mpGraphExecutor.py 86.97% <40.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand it but agree that is definitely the workaround that other people are using for that bug.

@andy-slac andy-slac merged commit 52cafcd into main Apr 13, 2023
@andy-slac andy-slac deleted the tickets/DM-38669 branch April 13, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants