Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #28

Closed
wants to merge 23 commits into from
Closed

Fix typos #28

wants to merge 23 commits into from

Conversation

jrob93
Copy link
Collaborator

@jrob93 jrob93 commented Oct 25, 2024

Change Description

Just some check typo fixes while I was working on the object_detection_controller branch.

Documentation Change Checklist

	new file:   forcedphot/odc.py
	new file:   forcedphot/query_args.txt
	new file:   tests/forcedphot/test_odc.py
	modified:   tests/forcedphot/ephemeris/test_data_loader.py
	modified:   tests/forcedphot/test_odc.py
	modified:   src/forcedphot/ephemeris/horizons_interface.py
	modified:   src/forcedphot/ephemeris/miriade_interface.py
	modified:   src/forcedphot/odc.py
	modified:   tests/forcedphot/ephemeris/test_ephemeris_client.py
	modified:   tests/forcedphot/ephemeris/test_horizons_interface.py
	modified:   tests/forcedphot/ephemeris/test_miriade_interface.py
	modified:   src/forcedphot/ephemeris/ephemeris_client.py
	modified:   src/forcedphot/odc.py
	modified:   tests/forcedphot/ephemeris/test_data_loader.py
	modified:   tests/forcedphot/test_odc.py
	modified:   tests/forcedphot/test_odc.py
	modified:   src/forcedphot/ephemeris/horizons_interface.py
	modified:   src/forcedphot/ephemeris/miriade_interface.py
	modified:   src/forcedphot/odc.py
	new file:   tests/forcedphot/ephemeris/data/query_args.txt
	new file:   tests/forcedphot/ephemeris/data/query_args2.txt
	new file:   tests/forcedphot/ephemeris/data/template_ephemeris.ecsv
Copy link

Thank you for your contribution to ssoforcedphot, a LINCC Framework package! 🌌 This checklist is meant to remind pull request reviewers of some common things to look for.

  • Do the proposed changes accomplish the desired goals and meet the acceptance criteria of the related issue?
  • Do the proposed changes follow the coding guidelines?
  • Are tests added/updated as needed? Are methods requiring network access mocked for offline testing?
  • Is there sufficient documentation for the changes?

@jrob93 jrob93 closed this Oct 25, 2024
Copy link

Before [578eec8] After [c1a7506] Ratio Benchmark (Parameter)
1.80±0.8s 2.95±1s ~1.64 benchmarks.time_computation
160 776 4.85 benchmarks.mem_list

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants