DM-48413: Adopt TEXT column types where useful #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Postgres there is no functional or performance difference between VARCHAR and TEXT columns. Therefore we're removing arbitrary constraints on many string columns by migrating to TEXT column types. This both lets us test database migrations and also prevents future issues where a column needs to have strings longer than the arbitrarily-set column type provides.
The steps for Times Square are slightly different from the generic Safir docs, so we'll provide the exact copy-and-pastable steps here.
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Jan 14, 2025
This enables the update schema job on idfdev for Times Square. See Times Square PR: lsst-sqre/times-square#89
jonathansick
force-pushed
the
tickets/DM-48413
branch
from
62a459b to
c9c5cf6
Compare
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Jan 16, 2025
This enables the update schema job on idfdev for Times Square. See Times Square PR: lsst-sqre/times-square#89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the database to use
TEXTcolumn types where previously we usedVARCHARcolumns with a (now unnecessary) length limit. This change requires a database migration on deployment. In Postgres there is no functional or performance difference betweenVARCHARandTEXTcolumns. This change simplifies the database schema and reduces the risk of future issues with column length limits.