DM-46095: Improve GitHub check run feedback #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the methods related to servicing GitHub Check Runs are part of the GitHubCheckRunService, which is apart from the GitHubRepoService. This should help make it easier to focus on the check run flow, apart from the functionality needed to sync data from GitHub.
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Sep 4, 2024
If the times-square.yaml file or the sidecar YAML files can't be parsed, we now format a check run annotation specifically to give feedback about that.
jonathansick
force-pushed
the
tickets/DM-46095
branch
2 times, most recently
from
814e0a1 to
3d20876
Compare
jonathansick
changed the title
If the Jinja templating in a notebook is incorrect, the PageModel.render_parameters method raises a new exception, PageJinjaError. This is captured in the notebook execution check run and turned into useful user feedback.
jonathansick
force-pushed
the
tickets/DM-46095
branch
from
3d20876 to
f0c0b89
Compare
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHubCheckRunServicefrom theGitHubRepoServiceEnsure that check runs always resolve and don't hang indefinitely.Defer to a subsequent PR that will also work with Noteburst for better feedback on notebook executions that time out.Example of catching the YAMLError when parsing invalid YAML:
Example of a Jinja formatting error: