DM-39186: Redo Redis connection configuration #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since adding more connection retry configuration, we have been seeing periodic "Connection closed by server" errors in all environments. One hypothesis is that setting socket_keepalive is keeping the connection open longer than the Redis server permits, and it's changing the error in a way that's causing this problem. Try dropping that configuration. Stop setting an explicit list of exceptions on which to retry, since the default seems to be fine.
We not infrequently have tests fail because the server run via uvicorn for Selenium testing takes more than 5s to start. Try increasing the timeout to 10s to see if this helps.
Do more Redis connection retries in the hope that we can survive a Redis upgrade without failing a bunch of requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding more connection retry configuration, we have been seeing periodic "Connection closed by server" errors in all environments. One hypothesis is that setting socket_keepalive is keeping the connection open longer than the Redis server permits, and it's changing the error in a way that's causing this problem. Try dropping that configuration.
Stop setting an explicit list of exceptions on which to retry, since the default seems to be fine.