DM-44541: Remove tokens from Redis if SQL write fails #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All token creation paths already created the token in Redis first and then added an entry to SQL, but if the SQL write failed for whatever reason, the Gafaelfawr call would fail but the token would be left behind in Redis. Instead, run the SQL code in a try/except block and try to remove the newly-created Redis key if the SQL write failed. This will hopefully reduce the number of orphaned tokens created during database failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All token creation paths already created the token in Redis first and then added an entry to SQL, but if the SQL write failed for whatever reason, the Gafaelfawr call would fail but the token would be left behind in Redis. Instead, run the SQL code in a try/except block and try to remove the newly-created Redis key if the SQL write failed. This will hopefully reduce the number of orphaned tokens created during database failures.