Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F] SummitData provider and basic flux query #333

Merged
merged 69 commits into from
Aug 21, 2023
Merged

[F] SummitData provider and basic flux query #333

merged 69 commits into from
Aug 21, 2023

Conversation

alexgoff
Copy link
Contributor

No description provided.

@alexgoff alexgoff added the feature Something new! label Jun 14, 2023
@alexgoff alexgoff requested a review from blnkt June 14, 2023 22:01
@alexgoff alexgoff self-assigned this Jun 14, 2023

const { temperature0: temperature, relativeHumidity, windSpeed } = data;

const temperatureData = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data that will need to be converted is grouped together

lib/api/efd.js Outdated
queryApi.queryRows(
flux`from(bucket: "${bucket}")
|> range(start: -60s)
|> filter(fn: (r) => r["_measurement"] == "lsst.sal.ESS.temperature" or r["_measurement"] == "lsst.sal.ESS.relativeHumidity" or r["_measurement"] == "lsst.sal.ESS.airFlow")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trimmed down to just the current data that we need: temperature, humidity, wind, and need to get precipitation

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@alexgoff alexgoff marked this pull request as ready for review June 20, 2023 17:30
useEffect(() => {
setLoading(true);

Promise.allSettled([
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Promise.allSettled so that one single failure won't disrupt the entire parallel fetch and we can keep it in loading status while they all catch up

const { tempUnit, windspeedUnit } = useWeatherUnit();
const { currentData: data, loading = true } = useSummitData();

if (loading && !data) return <Loader isVisible={true} />;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since loading won't go to false until all complete, we'll need to check in each container if the provider is loading and the data hasn't been set yet. Or we could go to individualized loading statuses but I think this is ok as-is

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

1 similar comment
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

3 similar comments
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@blnkt blnkt force-pushed the develop branch 8 times, most recently from c39e0ea to a340e73 Compare August 9, 2023 18:41
@blnkt blnkt force-pushed the EPO-8108 branch 2 times, most recently from de9c6d4 to f00a16e Compare August 21, 2023 18:53
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

1 similar comment
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@blnkt blnkt force-pushed the EPO-8108 branch 2 times, most recently from ee4b4b8 to 54844f9 Compare August 21, 2023 22:32
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@blnkt blnkt force-pushed the EPO-8108 branch 2 times, most recently from a9a2f62 to 9eb4e22 Compare August 21, 2023 23:00
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

1 similar comment
@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@github-actions
Copy link

A preview of this PR will be available at https://epo8108-dot-skyviewer.appspot.com until the request is closed.

@blnkt blnkt merged commit 48c17e8 into develop Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants