-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary proof-of-concept for whereContainsIn
#4
Conversation
EPO-8705 Preliminary proof-of-concept for `whereContainsIn`
Change Requests
|
I didn't look deeply at the code, but the approach is exactly how I'd do it. 👍 |
The second part of my previous request (breaking search term into words each of which is used to find matches) seems to be working as expected, but the first part would still seem to be an issue. Attached find a screengrab showing that the order of the keys seems to have a direct impact on what results are returned (i.e. different results for different order) AND that the order of the words in the search does NOT seem to have a direct impact on what results are returned (as expected). Screen.Recording.2024-02-28.at.12.32.51.PM.mov |
Interesting, I'll take a look at why that first issue is happening. What Canto album are you using?
We never talked about the ordering of the words in the search terms, I don't know where you're getting this idea from? |
Wait I'm not understanding what you're trying to show in that screen capture video, those are two completely different queries so returning different results would be expected? Edit: Nevermind now I see what you're saying, it's returning different results based on the ordering of the keys, I'll look into this |
Fixed issue w/merge() not modifying arr in place & instead returning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected. @ericdrosas87 please merge and cut a new release that includes this improvement.
EPO-8705 Preliminary proof-of-concept for
whereContainsIn
#390