Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize some constraints for the type classes #216

Merged
merged 14 commits into from
Jun 29, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jun 27, 2024

This pull request canonicalize some constraints for the type classes, and provides better generic deriving. Resolves #124.

@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from 8934e02 to b7c4e55 Compare June 28, 2024 01:50
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 35.03326% with 586 lines in your changes missing coverage. Please review.

Project coverage is 50.19%. Comparing base (d6a1ca1) to head (c743f91).

Files Patch % Lines
src/Grisette/Internal/Core/Data/Class/GPretty.hs 35.53% 105 Missing and 51 partials ⚠️
src/Grisette/Internal/Core/Data/Class/SOrd.hs 33.67% 63 Missing and 2 partials ⚠️
...c/Grisette/Internal/Core/Data/Class/EvaluateSym.hs 42.69% 44 Missing and 7 partials ⚠️
...Grisette/Internal/Core/Data/Class/SubstituteSym.hs 40.24% 44 Missing and 5 partials ⚠️
src/Grisette/Internal/SymPrim/AllSyms.hs 0.00% 47 Missing ⚠️
src/Grisette/Internal/Core/Data/Class/ToCon.hs 33.33% 38 Missing and 6 partials ⚠️
src/Grisette/Internal/Core/Data/Class/Mergeable.hs 36.92% 38 Missing and 3 partials ⚠️
src/Grisette/Internal/Core/Data/Class/SEq.hs 32.72% 34 Missing and 3 partials ⚠️
...sette/Internal/Core/Data/Class/ExtractSymbolics.hs 44.61% 31 Missing and 5 partials ⚠️
src/Grisette/Internal/Core/Data/Class/ToSym.hs 48.52% 30 Missing and 5 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   52.49%   50.19%   -2.30%     
==========================================
  Files         100      100              
  Lines        7971     8403     +432     
  Branches      665      706      +41     
==========================================
+ Hits         4184     4218      +34     
- Misses       3122     3479     +357     
- Partials      665      706      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from eed6c6f to f5f0cba Compare June 28, 2024 22:11
@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from c051385 to ed044f5 Compare June 28, 2024 23:09
@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from ed044f5 to 4286f9e Compare June 28, 2024 23:10
@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch 2 times, most recently from e33bd60 to de91a98 Compare June 29, 2024 01:06
@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from de91a98 to ad759c4 Compare June 29, 2024 01:10
@lsrcz lsrcz force-pushed the feat-canonicalize-constraints branch from fc57ca2 to c743f91 Compare June 29, 2024 01:26
@lsrcz lsrcz merged commit 0e0df28 into main Jun 29, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant