Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable rt_sigqueueinfo test which is failing with ethreads > 1 #837

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Disable rt_sigqueueinfo test which is failing with ethreads > 1 #837

merged 1 commit into from
Sep 28, 2020

Conversation

KenGordon
Copy link
Collaborator

Revert change to one test made in #832 as it fails in the CI with ethreads > 1.

@KenGordon
Copy link
Collaborator Author

Apologies. I was on holiday Thursday and Friday, travelling so I could turn up in person at the office...

@KenGordon KenGordon mentioned this pull request Sep 28, 2020
Merged
@vtikoo
Copy link
Contributor

vtikoo commented Sep 28, 2020

Does that mean #644 should be re-opened? That issue is specifically about rt_sigqueueinfo01.

@KenGordon
Copy link
Collaborator Author

Does that mean #644 should be re-opened? That issue is specifically about rt_sigqueueinfo01.

It passes with one ethread. I think there is a general problem with futex waiting. The return code of an interrupted futex wait ought to be EINTR (4) but is actually 516. I was investigating this on Wednesday before being away for the tgkill01 case. In that one if I replace the convoluted lkl tst_checkpoint call with a sleep the test passes. Perhaps I should create a new issue specifically for that but given I have discovered it as a contributory cause of the tgkill01 case I think it would be a duplicate.

This makes the CI pass again and I think that any discussion that delays that is not helping people know if they have broken anything.

@SeanTAllen SeanTAllen merged commit 06c43fd into oe_port Sep 28, 2020
@SeanTAllen SeanTAllen deleted the ken/disable_rt_sigqueueinfo_test branch September 28, 2020 15:16
@KenGordon
Copy link
Collaborator Author

See #838 for the futex problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtikoo vtikoo vtikoo approved these changes

@davidchisnall davidchisnall davidchisnall approved these changes

@SeanTAllen SeanTAllen SeanTAllen approved these changes

@hukoyu hukoyu Awaiting requested review from hukoyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenGordon @vtikoo @SeanTAllen @davidchisnall