Add windows-acl-permissions feature to fix perf issue on windows

[domsleee]

Attempted fix for performance issue mentioned in #200, for machines on a domain.

Benchmark

For a folder with 50 items.

Before change:
lsd took ~40 seconds

After change:

❯ hyperfine "lsd" --runs 50
Benchmark 1: lsd
  Time (mean ± σ):      39.4 ms ±   8.3 ms    [User: 0.6 ms, System: 0.6 ms]
  Range (min … max):    33.6 ms …  91.8 ms    50 runs

Other notes

I think it makes more sense for this to be disabled by default on windows due to performance, but I could be swayed.
My suggestion would be to use #866 (comment) as the default windows permissions behaviour.

P.S thanks for this great tool 🎉

---

TODO

• Use cargo fmt
• Add necessary tests (Not applicable imo)
• Add changelog entry
• Update default config/theme in README (if applicable)
• Update man page at lsd/doc/lsd.md (if applicable)

[muniu-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: domsleee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zwpaper]

hi @domsleee, thanks for the contribution, I am working on #882 to add a runtime flag instead of a build time feature for this.

can you have a look at that, and we can discuss which one would be good for users.

[domsleee]

Hi @zwpaper, a runtime flag is probably the better approach. I see in your PR that you are handling this issue as well, nice:

lsd: .: The specified domain either does not exist or could not be contacted. (os error 1355).

I have been able to reproduce this os error 1355 by disconnecting from the internet from my work machine.

I found a similar issue here: docker/for-win#2131 (comment)

I used process monitor and found, somewhat hilariously, that GetEffectiveRightsFromAclW is calling FSCTL_PIPE_TRANSCEIVE to fetch a file from a remote server!

Each read takes about a second, which explains why it was taking 45s for my 50 files 😄

[domsleee]

Since #882 is merged, I will close this one and open another PR for this comment: #882 (comment)