Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added complete color theming support for Git #852

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Added complete color theming support for Git #852

merged 3 commits into from
Jul 4, 2023

Conversation

k4yt3x
Copy link
Contributor

@k4yt3x k4yt3x commented Jun 2, 2023

I've noticed that the recently merged Git feature only has one default color, so I completed it. I've added a default color theme for it that looks like this (ignore the conflicted, I didn't bother actually making a repo for it):

image

... and with this theme of mine:

image

... it looks like this, works fine:

image

Edit: also suppressed ErrorKind::NotFound for Git status since if you don't this could happen when you are in a directory that's been deleted:

image


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@k4yt3x k4yt3x requested review from meain and Peltoche as code owners June 2, 2023 18:43
@muniu-bot
Copy link

muniu-bot bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k4yt3x

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #852 (6ee2cd4) into master (2fe3fcd) will increase coverage by 0.04%.
The diff coverage is 8.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   86.48%   86.52%   +0.04%     
==========================================
  Files          49       49              
  Lines        4602     4840     +238     
==========================================
+ Hits         3980     4188     +208     
- Misses        622      652      +30     
Impacted Files Coverage Δ
src/color.rs 43.98% <0.00%> (-5.47%) ⬇️
src/git.rs 90.41% <0.00%> (+2.45%) ⬆️
src/theme/color.rs 76.52% <100.00%> (-2.24%) ⬇️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@k4yt3x k4yt3x requested a review from zwpaper as a code owner July 1, 2023 21:54
@zwpaper
Copy link
Member

zwpaper commented Jul 4, 2023

thanks @k4yt3x! nice work!

@zwpaper zwpaper merged commit 71156b8 into lsd-rs:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants