Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support #820

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Localization support #820

merged 3 commits into from
Mar 13, 2023

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Mar 9, 2023

image

find locale set with sys-locale, then format with locales.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry

@scarf005 scarf005 requested review from meain and Peltoche as code owners March 9, 2023 02:43
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #820 (9630013) into master (ea56a7c) will increase coverage by 0.02%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   86.57%   86.60%   +0.02%     
==========================================
  Files          44       45       +1     
  Lines        4507     4515       +8     
==========================================
+ Hits         3902     3910       +8     
  Misses        605      605              
Impacted Files Coverage Δ
src/meta/inode.rs 87.50% <ø> (ø)
src/meta/links.rs 87.50% <ø> (ø)
src/meta/date.rs 94.53% <83.33%> (+0.17%) ⬆️
src/meta/locale.rs 100.00% <100.00%> (ø)
src/meta/mod.rs 54.18% <100.00%> (ø)
src/meta/name.rs 90.41% <100.00%> (ø)
src/meta/symlink.rs 82.75% <100.00%> (ø)
src/sort.rs 99.49% <100.00%> (ø)
tests/integration.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

scarf005 added 2 commits March 9, 2023 12:23
find locale set with sys-locale, then format with locales.
@zwpaper
Copy link
Member

zwpaper commented Mar 13, 2023

thanks for your help! @scarf005

@zwpaper zwpaper merged commit 7b9290c into lsd-rs:master Mar 13, 2023
@scarf005 scarf005 deleted the locale branch March 13, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants