Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not quote filename when piping to another program #748

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

TeamTamoad
Copy link
Contributor

According to GNU ls behavior, when piping the output to another program, the filename with special characters should not be quoted.

Old
image

New
image

Reference
image

Note

  • I put should_quote field in Flag struct because I think users should be able to configure this behavior. I'll submit another PR implementing that when I have time. What do you think?
  • I'm investigating the behavior of GNU ls about quoting and I'm not confident that the current implementation is full compatible with GNU ls. So, I think we should not release a new version soon.

TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #748 (f157267) into master (586e1c9) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   87.01%   86.98%   -0.04%     
==========================================
  Files          41       41              
  Lines        4628     4632       +4     
==========================================
+ Hits         4027     4029       +2     
- Misses        601      603       +2     
Impacted Files Coverage Δ
src/core.rs 0.00% <0.00%> (ø)
src/flags.rs 96.77% <0.00%> (-3.23%) ⬇️
src/meta/name.rs 90.41% <91.66%> (+0.03%) ⬆️
src/display.rs 84.19% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merelymyself
Copy link
Contributor

Probably relevant: #660

@meain
Copy link
Member

meain commented Oct 5, 2022

I put should_quote field in Flag struct because I think users should be able to configure this behavior. I'll submit another PR implementing that when I have time. What do you think?

Not sure if being able to decide if we quote would be useful. But, if we are decide on doing it, it could be [auto, always, never] like other options.

I'm investigating the behavior of GNU ls about quoting and I'm not confident that the current implementation is full compatible with GNU ls.

I had done some testing when the original PR was added, but do let me know if you find anything else.

PS: Add a changelog entry and I think we should be good with this PR.

@meain meain mentioned this pull request Oct 5, 2022
6 tasks
@meain meain merged commit 82acde7 into lsd-rs:master Oct 6, 2022
@TeamTamoad TeamTamoad deleted the fix-should-quote branch October 6, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants