-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quotes and escapes for necessary filenames #746
Conversation
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 86.99% 87.01% +0.02%
==========================================
Files 41 41
Lines 4589 4628 +39
==========================================
+ Hits 3992 4027 +35
- Misses 597 601 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but there seems to be some possible improvements suggested by clippy. Could you look into them:
I had an old version locally, woops. This should be good, will merge it in as soon as the CI passes.
I think those have already been fixed with the latest commits |
Fixes #660.
TODO
cargo fmt