Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icons alignment of various rendered width #1067

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ehwan
Copy link
Contributor

@ehwan ehwan commented Jun 22, 2024

For #1054.
Fixed icons to be right aligned.

Before

image
image
image

After

image
image
image

I'm not sure if it is OK to force right-align icons, but I think it is the simplest solution.

  • This follows the same logic as aligning 'Block::Size' or 'Block::SizeValue'.
  • However, for --tree, icons are aligned within same level of entries. If all entries in a directory have icons of width 1, no padding will be added even if there are icons with longer widths outside.

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@ehwan ehwan requested a review from zwpaper as a code owner June 22, 2024 13:35
@muniu-bot muniu-bot bot added the size/L label Jun 22, 2024
Copy link

muniu-bot bot commented Jun 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehwan
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant