-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed misaligned outputs and unicode-width dependency version #1064
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehwan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fix worked for me, running Debian on an rPi5. |
sorry for the late review, I have tested it and made sure it was really caused by the dependency break. let's merge this and create a release for it! |
thanks so much for the help @ehwan |
This could possibly fix misaligned output issues #1063
The problem occured only if when I
cargo install lsd
, not when I build it directly from the clone or install it viabrew
.This is because of the dependency
unicode-width
's version. The version installed viacargo install
was using the latestunicode-width
, v0.1.13, but others were using v0.1.11 because ofCargo.lock
.The dependency
unicode-width
had a breaking change between v0.1.11 and v0.1.13 that returns a different result when counting unicode characters.The new behavior in
unicode-width
v0.1.13 is more intuitive for calculating the length of a unicode string, so I fixed the logic accordingly.TODO
cargo fmt