Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subtitle/closed caption icons #1050

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

RuralAnemone
Copy link
Contributor

add subtitle/closed caption icons

uses U+F015E, 󰅞 for .890, .cip, .sbv, .scc, smi, and good old .vtt


TODONE

  • Use cargo fmt
  • Add necessary tests (n/a)
  • Update default config/theme in README (if applicable) (n/a)
  • Update man page at lsd/doc/lsd.md (if applicable) (n/a)

Copy link

muniu-bot bot commented May 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RuralAnemone
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the size/XS label May 18, 2024
@RuralAnemone
Copy link
Contributor Author

do you think 󰅞 or 󰶽 would be better? I'm honestly not sure which one fits more with the lsd theme...

image

@RuralAnemone
Copy link
Contributor Author

RuralAnemone commented May 18, 2024

this PR currently uses the first one

@RuralAnemone RuralAnemone marked this pull request as ready for review May 18, 2024 18:49
@RuralAnemone
Copy link
Contributor Author

rerunning tests

@RuralAnemone
Copy link
Contributor Author

I guess

@RuralAnemone
Copy link
Contributor Author

weird
idk

@zwpaper
Copy link
Member

zwpaper commented Jun 8, 2024

hi @RuralAnemone, sorry for the late reply, it's weird the CI keeps failing, I would look into it and make sure it's ok then merge the PR

@RuralAnemone
Copy link
Contributor Author

RuralAnemone commented Jun 8, 2024

it should be ok; I just added some more tuples to the icons array

I mean there might be a weird memory bug on windows or something but I doubt it

surely that isn't 2GB yet

@RuralAnemone
Copy link
Contributor Author

how could I have forgotten srt

@zwpaper zwpaper merged commit 3d9f04a into lsd-rs:master Aug 20, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants