Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1 #2

Merged
merged 8 commits into from
Jan 18, 2018
Merged

Issue 1 #2

merged 8 commits into from
Jan 18, 2018

Conversation

rouazana
Copy link
Contributor

Add missing attributes for #1

@coudot coudot self-requested a review January 17, 2018 15:15
@coudot
Copy link
Member

coudot commented Jan 17, 2018

Hi, some remarks:

  • The version should be 1.4 (latest release is 1.3)
  • Build failed, you may have to fix the repo to get the lsc-core.jar

@rouazana
Copy link
Contributor Author

rouazana commented Jan 17, 2018 •
edited
Loading

The version should be 1.4 (latest release is 1.3)

Good catch, sorry.

Build failed, you may have to fix the repo to get the lsc-core.jar

Fixed (but for oracle7, but it seems to be a travis issue)

coudot
coudot requested changes Jan 17, 2018
View reviewed changes
Copy link
Member

@coudot coudot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to change file name in lsc-obm-plugin.docs

@rouazana
Copy link
Contributor Author

It would be better to change file name in lsc-obm-plugin.docs

Done

@rouazana rouazana mentioned this pull request Jan 17, 2018
Merged
@rouazana rouazana merged commit 43f3e3d into lsc-project:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coudot coudot coudot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouazana @coudot