Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12 Do not delete entry if get script returns an error #13

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Fix #12 Do not delete entry if get script returns an error #13

merged 1 commit into from
Jan 6, 2022

Conversation

soisik
Copy link
Contributor

@soisik soisik commented Jan 4, 2022

No description provided.

@coudot coudot requested review from remk and rouazana January 4, 2022 08:59
rouazana
rouazana approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@rouazana rouazana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice tests!

@soisik soisik merged commit 0c04bdf into lsc-project:master Jan 6, 2022
@soisik soisik deleted the fix-entry-deleted-on-script-error branch January 6, 2022 07:54
@coudot coudot added this to the 1.1 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouazana rouazana rouazana approved these changes

@remk remk Awaiting requested review from remk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@soisik @rouazana @coudot