Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quaternion default initialisation #300

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix quaternion default initialisation #300

wants to merge 5 commits into from

Commits on Mar 20, 2024

  1. Change default initialization for Quaternions to 0 + 0i + 0j + 0k 

    The current initialization is neither the identity quaternion
1 + 0i + 0j + 0k (Q(w = 1, x = 0, y = 0, z = 0)) nor represents a pure rotation
as it is not normalized. Therefore revert changes made earlier
returning to Q(0,0,0,0).

Note: Initialisation to Q(0,0,0,0) is beneficial for performance reasons
to Q(1,0,0,0).

Signed-off-by: Christoph Niethammer <[email protected]>
    @cniethammer
    cniethammer committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    879cbf3 View commit details
    Browse the repository at this point in the history

  2. Align names of parameters in Molecule constructors with Quaternion pa… 

    …rameters

Signed-off-by: Christoph Niethammer <[email protected]>
    @cniethammer
    cniethammer committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    32d6e83 View commit details
    Browse the repository at this point in the history

  3. Fix initialization of molecule orientation in internal generator code 

    Signed-off-by: Christoph Niethammer <[email protected]>
    @cniethammer
    cniethammer committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4fe755b View commit details
    Browse the repository at this point in the history

  4. Add cubic_gird_generator example to test configuration list 

    Signed-off-by: Christoph Niethammer <[email protected]>
    @cniethammer
    cniethammer committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    561259f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Change Molecule constructor to require passing all parameters 

    Remove the default parameters for the Molecule constructor to prevent
unintentional incorrect initialization of molecules. Fix all related
places in the code with the appropriate initialization values.

Signed-off-by: Christoph Niethammer <[email protected]>
    @cniethammer
    cniethammer committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    be75df9 View commit details
    Browse the repository at this point in the history