Skip to content

Commit

Permalink
Fix switch-window for msedgedriver
Browse files Browse the repository at this point in the history
  • Loading branch information
lread committed May 14, 2022
1 parent f699010 commit f4dbffc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* https://github.com/clj-commons/etaoin/issues/384[#384]: Look for `safaridriver` on PATH by default
* https://github.com/clj-commons/etaoin/issues/402[#402]: Only send body for webdriver `POST` requests to appease `safaridriver`
* https://github.com/clj-commons/etaoin/issues/403[#403]: The `select` fn now clicks on the `select` element before clicking the `option` element to appease `safaridriver`
* https://github.com/clj-commons/etaoin/issues/408[#408]: Fix `switch-window` for `msedgedriver`
* Docs
** https://github.com/clj-commons/etaoin/issues/393[#393]: Add changelog
** https://github.com/clj-commons/etaoin/issues/396[#396]: Move from Markdown to AsciiDoc
Expand Down
12 changes: 2 additions & 10 deletions src/etaoin/api.clj
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,8 @@
:path [:session (:session driver) :window]
:data {:handle handle}}))

(defmethod switch-window
:phantom
[driver handle]
(execute {:driver driver
:method :post
:path [:session (:session driver) :window]
:data {:name handle}}))

(defmethod switch-window
:chrome
(defmethods switch-window
[:chrome :edge :phantom]
[driver handle]
(execute {:driver driver
:method :post
Expand Down

0 comments on commit f4dbffc

Please sign in to comment.