Skip to content

Commit

Permalink
Stop testing PhantomJS
Browse files Browse the repository at this point in the history
Existing code that supports PhantomJS remains, but we are no longer
launching tests for the, presumably obsolete, PhantomJS.

Closes clj-commons#388
  • Loading branch information
lread committed May 12, 2022
1 parent a613bfe commit 1bfd976
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
== Unreleased

* https://github.com/clj-commons/etaoin/issues/383[#383]: Drop testing for Safari on Windows
* https://github.com/clj-commons/etaoin/issues/388[#388]: Drop testing for PhantomJS
* Docs
** https://github.com/clj-commons/etaoin/issues/393[#393]: Add changelog
* Internal quality
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ RUN printf '#!/bin/sh\nXvfb :99 -screen 0 1280x1024x24 &\nexec "$@"\n' > /tmp/en
&& chmod +x /tmp/entrypoint \
&& mv /tmp/entrypoint /entrypoint.sh

ENV ETAOIN_TEST_DRIVERS="[:firefox :chrome :phantom]"
ENV ETAOIN_TEST_DRIVERS="[:firefox :chrome]"

ENTRYPOINT ["/entrypoint.sh"]
8 changes: 4 additions & 4 deletions test/etaoin/api_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@

(defn get-drivers-from-prop []
(case (first (str/split (System/getProperty "os.name") #"\s+"))
"Linux" [:firefox :chrome :phantom]
"Mac" [:chrome :edge :firefox :phantom :safari]
"Windows" [:firefox :chrome :edge :phantom]
"Linux" [:firefox :chrome]
"Mac" [:chrome :edge :firefox :safari]
"Windows" [:firefox :chrome :edge]
nil))

(defn get-default-drivers []
[:firefox :chrome :phantom :safari])
[:firefox :chrome :safari])

(def default-opts
{:chrome {:args ["--no-sandbox"]}
Expand Down

0 comments on commit 1bfd976

Please sign in to comment.